-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💡 Version 0.0.5 #41
Merged
Merged
💡 Version 0.0.5 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Imported gitignore from branch is-31.
+ Added folder and __init__ file for the new module + Updated old Copyright notes in the package. + Updated AUTHOR section on documentation to avoid it getting outdated.
+ Added classes for parents and elements of d-extension + Added a specific implementation using libsingular multivariate polynomials
+ Implemented __init__ for both elements and singular elements. + Implemented methods coefficients, monomials and coefficient for elements. + Moved checkings on DExtension to the factory.
+ Added also default behavior on DifferentialRing and DIfferenceRing when no operations are given.
+ Added .dextension to default imports + Added method sage_ring to return a valid sage ring always. + Added polydict implementation for DExtension
+ Taking changes after issue #31 - Fixing merging conflicts
- Remove method "sage_ring": waiting for a refactor of the module dextension_parent - Change the conversion behavior: rollback to original bechavior + Added import to logging to avoid errors.
- Changed the rank of DPolynomialRing functor: now it is less relevant than the dExtension. + Finished a first version of dExtension both for parent and element. - Changed the checking for coercion for DRing_Wrapper. There was some erros when casting from QQ to a wrapping with the zero derivative.
- Important: changed the adjustment from MPolynomial categories to DRings: the method _refine_category_ is the key!!
+ Changed done to prevent colision with other methods in SageMath + Change _coerce_map_from_ for Wrapped D-rings to be more precise.
+ Added special __getattr__ for wrapped rings. + Added method variables to FractionField elements. + Added methods for univariate d-Extensions: - "polynomial", - "content", - "monic", - "quo_rem", - "pseudo_quo_rem", - "xgcd_half", - "xgcd", - "diophantine_half", - "diophantine" + Implemented methods "remove_var" and "univariate_ring" to DExtension_parent + Improved coercion system to consider the recursive DExtensions. + Added a dependency graph for the operations on a DExtension.
- Changed _pushout_ to recognize the wrapped directly - Changed _coerce_map_from_ to detect wrapped directly + Added __getattr__ to the elements of Wrapped rings. - Removed unnecessary methods ("is_one", "is_zero" and "is_unit")
+ Added quo_rem for multivariate polynomials: using the leading term. + Coefficients are reduced when creating the elements. - Changed default orderring of monomials: now is set to "lex" ordering. - Changed __call__ for DExtensions: now it detects elements in the field of fractions in the coefficients if necessary.
- Added implementation of partial fraction decomposition - Added implementation of squarefree factorization * Implemented Musser's algorithm * Implemented Yun's algorithm
+ Added notebook for ACA
- Added option to obtain the polynomial P_0 in "almost_commuting". By definition, it is the identity operator. - Fixed returned value in "sym_power" when exponent was 0.
- Improved latex representation - Added method to evaluate coefficients of d-polynomials - Improved "eval" method: first evaluate coefficients, then evaluate the remaining d-polynomial.
- DRing_Wrapper now accepts generic DRing_Wrappers without checking operation compatibility.
* Added method _maple_ in the class DPolynomial * Added test for the method _maple_
* Changed behavio to allow polynomials without the differential operator. * Fixed error when the polynomial was zero. * Added tests for new cases.
* Results will be included in a new repository (da_wilson) * The folder will still be used as an internal cache, but its results will not be updated on the repository itself.
* Updated CI dynamics using TOX * Prepared new VERSION number
* Fixed method "coefficient" to allow the empty list as an input. This method now converts the input to a DMonomial. * Added method (with tests) for computing the coefficient that do not involve some d-variables --> "coefficient_without_var". * Fixed __eq__ method for DPolynomial. Now it first check if the monomials/coefficients coincide. If that fails, it use the usual __eq__ method with coercion. * Added method __ne__ to DPolynomial to properly implement the != operator. * Improve method "_maple_" * Improved method "__process_sylvester_arguments" to allow an index for the generator to be used. * Fixed doctest to fit the new format.
* It now includes the new -tox routines for linting and testing.
* Fixed all warnings provided by pycodestyle-minimal * Fixed all errors from relint * Fixed typo in .yml file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
repository
Issues related with CI and the structure of repository
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request including results for computing the Wilson's almost commuting basis in a consistent way.
This pull request includes:
It also includes some other improvements such as: