Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom hooks Frontend #190

Closed
AntonioMrtz opened this issue Aug 10, 2024 · 5 comments · Fixed by #193
Closed

Custom hooks Frontend #190

AntonioMrtz opened this issue Aug 10, 2024 · 5 comments · Fixed by #193
Assignees
@AntonioMrtz
Labels
backend Backend related issues frontend Frontend related issues refactor Code changes or improvements that do not change code behaviour

Comments

@AntonioMrtz
Copy link
Owner

AntonioMrtz commented Aug 10, 2024 •
edited
Loading

Description

Encapsulate fetch logic inside custom hooks and replace fetch.then for await. Add OpenAPI client to frontend

Context

Code repetition on queries has become a problem. Changing backend endpoints became harder because of multiple components having the same query spread all over the code.

How to do it

  • Refactor common fetch queries in custom hooks
  • Replace then for await
  • Include Swagger OpenAPI client

Testing
@AntonioMrtz AntonioMrtz added frontend Frontend related issues refactor Code changes or improvements that do not change code behaviour labels Aug 10, 2024
@AntonioMrtz AntonioMrtz self-assigned this Aug 10, 2024
AntonioMrtz added a commit that referenced this issue Aug 11, 2024
@AntonioMrtz
chore: minor changes to comments | [#190]
5209a30
AntonioMrtz added a commit that referenced this issue Aug 11, 2024
@AntonioMrtz
feat: context menu playlist/song getting playlist names using onl one…
d7a2c7b 
… query | [#190]
AntonioMrtz added a commit that referenced this issue Aug 11, 2024
@AntonioMrtz
fix: mongomock modules only loaded if TEST ENV_VALUE is selected | [#190
0852190 
]
AntonioMrtz added a commit that referenced this issue Aug 11, 2024
@AntonioMrtz
ci: update precommit to ignore end of line json openapi schema | [#190]
2261aa3
AntonioMrtz added a commit that referenced this issue Aug 11, 2024
@AntonioMrtz
ci: update precommit to ignore end of line json openapi schema | [#190]
5762c52
AntonioMrtz added a commit that referenced this issue Aug 11, 2024
@AntonioMrtz
refactor: delete playlist using await instead of then | [#190]
c7ddaaa
AntonioMrtz added a commit that referenced this issue Aug 11, 2024
@AntonioMrtz
refactor: refreshSidebarData unified function name | [#190]
a88b5cc
AntonioMrtz added a commit that referenced this issue Aug 11, 2024
@AntonioMrtz
refactor: unify changeSongName | [#190]
ec60d10
AntonioMrtz added a commit that referenced this issue Aug 11, 2024
@AntonioMrtz
fix: rename misleading function to get_user_playlists_names | [#190]
969aac8
@AntonioMrtz AntonioMrtz added the backend Backend related issues label Aug 12, 2024
AntonioMrtz added a commit that referenced this issue Aug 12, 2024
@AntonioMrtz
feat: add OpenAPI Client | [#190]
cf71446
AntonioMrtz added a commit that referenced this issue Aug 12, 2024
@AntonioMrtz
feat: load openapi client settings on app init | [#190]
221898a
AntonioMrtz added a commit that referenced this issue Aug 13, 2024
@AntonioMrtz
chore: generate-openapi-client npm run script | [#190]
0949237
@AntonioMrtz AntonioMrtz linked a pull request Aug 13, 2024 that will close this issue
#190: Custom Hooks Frontend #191
Merged
AntonioMrtz added a commit that referenced this issue Aug 13, 2024
@AntonioMrtz
ci: openapi pipeline for generate schema and client then run frontend…
eae8601 
… tests | [#190]
AntonioMrtz added a commit that referenced this issue Aug 13, 2024
@AntonioMrtz
Revert "#190: Custom Hooks Frontend"
5f8cb4b
@AntonioMrtz AntonioMrtz reopened this Aug 13, 2024
AntonioMrtz added a commit that referenced this issue Aug 13, 2024
@AntonioMrtz
Merge pull request #192 from AntonioMrtz/revert-191-feat/190-custom-h…
e9586e2 
…ooks-frontend

Revert "#190: Custom Hooks Frontend"
AntonioMrtz added a commit that referenced this issue Aug 13, 2024
@AntonioMrtz
ci: restore frontend tests on PR commit and open api generation to be…
d2b2494 
… only executed if PR merged | [#190]
@AntonioMrtz AntonioMrtz removed a link to a pull request Aug 13, 2024
#190: Custom Hooks Frontend #191
Merged
@AntonioMrtz AntonioMrtz linked a pull request Aug 13, 2024 that will close this issue
#190: Custom Hooks Frontend #193
Merged
AntonioMrtz added a commit that referenced this issue Aug 13, 2024
@AntonioMrtz
feat: remove credentials include on every frontend fetch | [#190]
17c9897
AntonioMrtz added a commit that referenced this issue Aug 13, 2024
@AntonioMrtz
feat: add hooks for seach item by name and get genres | [#190]
9c2b908
AntonioMrtz added a commit that referenced this issue Aug 13, 2024
@AntonioMrtz
feat: use openapi client for startmenu and registermenu | [#190]
a4e00c1
AntonioMrtz added a commit that referenced this issue Aug 13, 2024
@AntonioMrtz
feat: add get user relevant playlists hook | [#190]
a51e7e6
AntonioMrtz added a commit that referenced this issue Aug 13, 2024
@AntonioMrtz
refactor: create song and playlist using openapi client | [#190]
cd49945
AntonioMrtz added a commit that referenced this issue Aug 13, 2024
@AntonioMrtz
chore: remove unused dependency testing frontend | [#190]
e164826
AntonioMrtz added a commit that referenced this issue Aug 15, 2024
@AntonioMrtz
fix: remove openapi server URL because of CORS errors on local dev | [#…
14a45b5 
…190]
AntonioMrtz added a commit that referenced this issue Aug 15, 2024
@AntonioMrtz
fix: update playlist backend use old method not compatible with mongo…
4707737 
…mock | [#190]
AntonioMrtz added a commit that referenced this issue Aug 15, 2024
@AntonioMrtz
feat: improve Playlist/sidebar refresh and refactor Playlist and Star…
f9c8516 
…tMenu | [#190]
AntonioMrtz added a commit that referenced this issue Aug 15, 2024
@AntonioMrtz
test: jest init OpenAPI base url and credentials before tests run | [#…
8d10960 
…190]
AntonioMrtz added a commit that referenced this issue Aug 15, 2024
@AntonioMrtz
feat: use openapi client on contextmenuplaylist operations | [#190]
a30dc6c
AntonioMrtz added a commit that referenced this issue Aug 15, 2024
@AntonioMrtz
fix: skipped test making tests fail | [#190]
da5966b
AntonioMrtz added a commit that referenced this issue Aug 15, 2024
@AntonioMrtz
docs: improve develop frontend testing | [#190]
4a5d1fe
AntonioMrtz added a commit that referenced this issue Aug 20, 2024
@AntonioMrtz
refactor: add openapi client to contextmenusong | [#190]
ba9fdab
AntonioMrtz added a commit that referenced this issue Aug 21, 2024
@AntonioMrtz
refactor: use openapi client on song players | [#190]
807c453
AntonioMrtz added a commit that referenced this issue Sep 1, 2024
@AntonioMrtz
feat: replace fetchs for hooks usage for AdvancedUIComponents Allitem…
55bdc38 
…s (Playlist-Songs-Artists) | [#190]
@AntonioMrtz
Copy link
Owner Author

Custom Hooks refactor Frontend

AntonioMrtz added a commit that referenced this issue Sep 7, 2024
@AntonioMrtz
test: add missing backend tests for get_artist_songs_correct and get_…
d818c32 
…user_playlists | [#190]
AntonioMrtz added a commit that referenced this issue Sep 7, 2024
@AntonioMrtz
Merge pull request #193 from AntonioMrtz/feat/190-custom-hooks-frontend
978fc76 
#190: Custom Hooks Frontend
@AntonioMrtz
Copy link
Owner Author

get playlists by user

@AntonioMrtz
Copy link
Owner Author

Make all frontend request to include credentials without repeating code

@AntonioMrtz
Copy link
Owner Author

Generate client pipelines

@AntonioMrtz
Copy link
Owner Author

Investigar contrato Frontend-Backend con openapi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntonioMrtz AntonioMrtz

Labels
backend Backend related issues frontend Frontend related issues refactor Code changes or improvements that do not change code behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#190: Custom Hooks Frontend AntonioMrtz/SpotifyElectron
1 participant
@AntonioMrtz