Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Database Connection and Providers typing and code quality #210

Closed
AntonioMrtz opened this issue Sep 8, 2024 · 0 comments · Fixed by #211
Closed

Improve Database Connection and Providers typing and code quality #210

AntonioMrtz opened this issue Sep 8, 2024 · 0 comments · Fixed by #211
Assignees
@AntonioMrtz
Labels
backend Backend related issues refactor Code changes or improvements that do not change code behaviour

Comments

@AntonioMrtz
Copy link
Owner

Description

Improve Database Connection and Providers typing and code quality

Context

  • Types where disabled for database connections and providers
  • Long(characters) calls for getting connections and song service

How to do it

  • Improve type system for providers and database connections
  • Simplify database connection init and getter
  • Shorten imports and calls(characters)

Testing
@AntonioMrtz AntonioMrtz added backend Backend related issues refactor Code changes or improvements that do not change code behaviour labels Sep 8, 2024
@AntonioMrtz AntonioMrtz self-assigned this Sep 8, 2024
AntonioMrtz added a commit that referenced this issue Sep 8, 2024
@AntonioMrtz
refactor: simplify connections and providers | [#210]
5a75d54 
* Shorten number of characters needed to get connections and providers
* Improve type system for database connections and providers
* Fix typo environment word
@AntonioMrtz AntonioMrtz mentioned this issue Sep 8, 2024
Merged
@AntonioMrtz AntonioMrtz linked a pull request Sep 8, 2024 that will close this issue
#210: Improve Database Connection and Providers typing and code quality #211
Merged
AntonioMrtz added a commit that referenced this issue Sep 8, 2024
@AntonioMrtz
fix: rename DatabaseConnection file to DatabaseConnectionManager | [#210
080e45a 
]
AntonioMrtz added a commit that referenced this issue Sep 8, 2024
@AntonioMrtz
chore: typos and unused linter rule annotation | [#210]
5c82fbf
AntonioMrtz added a commit that referenced this issue Sep 8, 2024
@AntonioMrtz
chore: environment missing mayus on first letter | [#210]
98e0378
AntonioMrtz added a commit that referenced this issue Sep 8, 2024
@AntonioMrtz
* refactor: simplify connections and providers | [#210] * Shorten num…
63ea146 
…ber of characters needed to get connections and providers * Improve type system for database connections and providers * Fix typo environment word

* refactor: simplify connections and providers | [#210]

* Shorten number of characters needed to get connections and providers
* Improve type system for database connections and providers
* Fix typo environment word

* fix: rename DatabaseConnection file to DatabaseConnectionManager | [#210]

* chore: typos and unused linter rule annotation | [#210]

* chore: environment missing mayus on first letter | [#210]
AntonioMrtz added a commit that referenced this issue Sep 8, 2024
@AntonioMrtz
* refactor: simplify connections and providers | [#210] * Shorten num…
f70cffd 
…ber of characters needed to get connections and providers * Improve type system for database connections and providers * Fix typo environment word

* refactor: simplify connections and providers | [#210]

* Shorten number of characters needed to get connections and providers
* Improve type system for database connections and providers
* Fix typo environment word

* fix: rename DatabaseConnection file to DatabaseConnectionManager | [#210]

* chore: typos and unused linter rule annotation | [#210]

* chore: environment missing mayus on first letter | [#210]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntonioMrtz AntonioMrtz

Labels
backend Backend related issues refactor Code changes or improvements that do not change code behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#210: Improve Database Connection and Providers typing and code quality AntonioMrtz/SpotifyElectron
1 participant
@AntonioMrtz