-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstring rules to Ruff linting configuration #142
Add docstring rules to Ruff linting configuration #142
Conversation
Hi @xiomaraR , Im glad you contributed again, I wasn't sure because i didnt notice u take the issue. It helps me a lot to get track of the tasks state. The PR is good but i think we can expand it a bit if its OK to you. Now that the linter run with the newest rules i think we can make minor adjustments.
I updated the issue with the new scope of the PR :) #136 |
Ok, good to know. I assumed you'd be notified that I assigned myself. I'll leave a comment next time. I'll work on the new tasks soon! Also, I don't mind updating the docs for the modules, or splitting them with you? |
No worries with package docs, mainly I want to do them by myself so I can represent exactly what was the original purpose of the package according to the app architecture. It will be a bit hard to make docs of some of the already existing packages. Tho I appreciate your willingness to help :). |
If you dont mind I will be pushing module docs to your forked repo so we can unify the PR content and work on the same branch. |
Hi @xiomaraR , package level missing docs are already pushed. The only remaining thing will be exclude the mentioned rules in tests modules |
Bringing latest changes from master into the docstring configuration rules branch to ensure compatibility and avoid merge conflicts.
…/xiomaraR/SpotifyElectron into chore/add-docstring-config-rules
All good @xiomaraR , thanks for another contribution. If you want to dig deeper into the project i could suggest issue #129. I'm planning on rethinking backend tests pipelines, they only work if the branches are being created directly on the base repo because of enviroment variables. Soon I will use mongodb mock for mocking a database instance for BLOB architecture tests. |
Description
This pull request aims to enforce docstring configuration rules for public modules, classes, and methods in the project.
Commit type
chore
Issue
This pull request addresses #136
Solution
The solution involves modifying the lint section in the
Backend/ruff.toml
file to include docstring configuration rules for public modules, classes, and methods.Proposed Changes
Backend/ruff.toml
:Potential Impact
These changes will improve code readability and maintainability by ensuring consistent documentation standards. Ignoring D100 and D103 in the tests/ folder will prevent linting errors on test files. Enforcing Google-style docstrings will streamline the documentation style.
Tests Performed
Screenshots
N/A
Additional Tasks
N/A
Assigned
@AntonioMrtz