#133: Disable upload song button while processing request

[ObuMan]

Description

• Added disabled={loadingUploadSong} to the song upload button.
• To manually check if the button really becomes unavailable when uploading a song, I made a post request to the route http://127.0.0.1:8000/artists/?name=ArtistName&photo=http://photo.jpg&password=Password, thereby creating a new user with the role 'Artist'. Next step I logged in as the user I just created. And already from this account I uploaded the song and checked whether the button really became unavailable for pressing.
• Created a unit test to test the behavior of the button

Commit type

feat: indicates the addition of a new feature or functionality to the project.

Issue

Modify the behaviour of upload song button so its disabled while waiting for the song to be uploaded.

Solution

Added disabled={loadingUploadSong} to the song upload button

Proposed Changes

• Added disabled={loadingUploadSong} to the song upload button
• A test to check if the button is really unavailable while the song is loading

Potential Impact

Screenshots

Additional Tasks

Assigned

@AntonioMrtz

[AntonioMrtz]

Hi @ObuMan , thanks for your time . I Will check the PR tomorrow :)

[AntonioMrtz]

Hi @ObuMan , code looks good. I runned the pipelines and:

• Run npm run format:write so the format pipeline doesn't fail.
• Run npm run lint to check the error we're getting from the linter. You can see the ouput here

Thanks for your time and keeping the format and workflow of the contributions. Are you interested in taking more issues? If you find this project interesting/helpful, I'd appreciate it if you could star the repo!

[ObuMan]

Hi, I just noticed that some checks were not successful. I am trying to fix it.

[ObuMan]

At the expense of more issues. Yes, I would be very interested in that

[AntonioMrtz]

Hi @ObuMan , I'm still seeing errors in pipeline:

Lint

/home/runner/work/SpotifyElectron/SpotifyElectron/Electron/src/__tests__/components/Sidebar/AddSongPlayListAccordion.test.tsx
Error:   2:34  error  'waitFor' is defined but never used  @typescript-eslint/no-unused-vars

Format

Checking formatting...
[warn] src/__tests__/components/Sidebar/AddSongPlayListAccordion.test.tsx
[warn] Code style issues found in the above file. Run Prettier to fix.

[AntonioMrtz]

@ObuMan Lint pipeline is successful but style is not. Run npm run format:write.

Checking formatting...
[warn] src/__tests__/components/Sidebar/AddSongPlayListAccordion.test.tsx
[warn] Code style issues found in the above file. Run Prettier to fix.

[AntonioMrtz]

Hi @ObuMan . I will check the final version tomorrow :). Thanks for your time

[AntonioMrtz]

HI @ObuMan , everything looks good :) . I will merge the PR as soon as possible. Maybe you want to check #255 , it's an small quality of life adjustment to the Playlist section. Let me know what you think 👍