Improvements

- Removed Download timeout on benchmark - Improved UX - Fixed benchmark alias
Antonito · Apr 2, 2019 · 0d6c7fb · 0d6c7fb
1 parent 42eb50c
commit 0d6c7fb
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 13 deletions.
diff --git a/cmd/bench/cmd.go b/cmd/bench/cmd.go
@@ -25,7 +25,7 @@ func New() cli.Command {
 	log.Traceln("Installing 'bench' command")
 	return cli.Command{
 		Name:    "bench",
-		Aliases: []string{"sb"},
+		Aliases: []string{"b"},
 		Usage:   "Benchmark the connexion",
 		Action:  handler,
 		Flags: []cli.Flag{

diff --git a/internal/session/session.go b/internal/session/session.go
@@ -62,6 +62,8 @@ func (s *Session) CreateConnection(onConnectionStateChange func(connectionState
 // ReadSDP from the SDP input stream
 func (s *Session) ReadSDP() error {
 	var sdp webrtc.SessionDescription
+
+	fmt.Println("Please, paste the remote SDP:")
 	for {
 		encoded, err := utils.MustReadStream(s.sdpInput)
 		if err == nil {

diff --git a/pkg/session/bench/session.go b/pkg/session/bench/session.go
@@ -1,8 +1,6 @@
 package bench
 
 import (
-	"fmt"
-
 	"github.com/pions/webrtc"
 	log "github.com/sirupsen/logrus"
 )
@@ -40,7 +38,6 @@ func (s *Session) createMasterSession() error {
 		return err
 	}
 
-	fmt.Println("Please, paste the remote SDP:")
 	if err := s.sess.ReadSDP(); err != nil {
 		log.Errorln(err)
 		return err
@@ -49,13 +46,11 @@ func (s *Session) createMasterSession() error {
 }
 
 func (s *Session) createSlaveSession() error {
-	fmt.Println("Please, paste the remote SDP:")
 	if err := s.sess.ReadSDP(); err != nil {
 		log.Errorln(err)
 		return err
 	}
 
-	fmt.Println("SDP:")
 	if err := s.sess.CreateAnswer(); err != nil {
 		log.Errorln(err)
 		return err

diff --git a/pkg/session/bench/state_download.go b/pkg/session/bench/state_download.go
@@ -2,7 +2,6 @@ package bench
 
 import (
 	"fmt"
-	"time"
 
 	"github.com/pions/webrtc"
 	log "github.com/sirupsen/logrus"
@@ -30,16 +29,10 @@ func (s *Session) onOpenHandlerDownload(dc *webrtc.DataChannel) func() {
 			log.Warningln("No DataChannel provided")
 		}
 
-		timeoutErr := time.After(s.testDurationError)
-
 		fmt.Printf("Downloading random datas ... (%d s)\n", int(s.testDuration.Seconds()))
 	DOWNLOAD_LOOP:
 		for {
 			select {
-			case <-timeoutErr:
-				log.Error("Download time'd out")
-				break DOWNLOAD_LOOP
-
 			case <-s.downloadDone:
 				log.Traceln("Done downloading")
 				break DOWNLOAD_LOOP