Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for booting snapshots on LUKS encrypted disk #333

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cip91sk
Copy link

@cip91sk cip91sk commented Jun 4, 2024

Fixes #260

@Schievel1
Copy link
Collaborator

Thank you very much. Can you also add some description on the setting in the man pages and the readme?

@cip91sk
Copy link
Author

cip91sk commented Jun 7, 2024

Sure! I will hopefully do it in a couple days

@cip91sk
Copy link
Author

cip91sk commented Jun 8, 2024

Done, let me know if I need to change anything!

Copy link

@linduxed linduxed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't gotten around to testing this branch on my system, but I found one thing that seemed worth commenting on anyway.

list_insmods+=("insmod cryptodisk")
list_insmods+=("insmod luks")
list_insmods+=("insmod gcry_rijndael")
list_insmods+=("insmod gcry_rijndael")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak to the bigger picture of what should and shouldn't be added with insmod, but this particular line is duplicated. Should it be duplicated?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. Honestly I merely copy-pasted what I saw in my grub.cfg , and apparently also in the related issue the insmod list for the user that opened it contains the same duplication . Anyway I tried to boot a snapshot without the duplication and it works, so I don't really know if it's best to do the same duplication as "default" grub does or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to boot into snapshots that are on LUKS encrypted disk
3 participants