associatedtype DecodedType #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This to enable non-final classes to also conform to Decodable. Argo does it.
|
Closing this for now as a lot of things have become structs. Could be revisited in the future though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building upon #79, this makes Decodable more similar to Argo and makes class conformance to
Decodableless painful. Have not used this a lot yet, so not fully aware of the effects yet.The following types now conform to
Decodable:NSArrayNSDictionaryNSURLWaiting with possibly completing/merging this until official Swift 3 beta. "Complete generics" might also create a choice between this and other features. And, if Foundation classes are made final or the underlying JSON Deserialization is changed for a more swifty version this is most likely overkill. Personally need it now though.
Todo:
decodeAsOneOf