Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gas limit default #21

Merged
merged 12 commits into from
Oct 4, 2023
Merged

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Oct 4, 2023

What I did

I noticed the block gas limit was extremely high in Arbitrum networks.
It is 1125899906842624 in arb and like 30000000 in eth and opimism and polygon.
You can read more about it here: https://cointelegraph.com/learn/arbitrum-the-next-generation-layer-2-for-ethereum

fixes: ApeWorX/ape#1686
Fixes: APE-1430

How I did it

Hardcode a more realistic gas limit that should always work in testing.

How to verify it

Run the code from the linked core issue, things should work now.

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@vany365 vany365 changed the title fix: gas limit fix: gas limit [APE-1433] Oct 4, 2023
@antazoey antazoey changed the title fix: gas limit [APE-1433] fix: gas limit default Oct 4, 2023
@antazoey antazoey requested a review from dtdang October 4, 2023 20:40
@antazoey antazoey merged commit 29aa758 into ApeWorX:main Oct 4, 2023
11 checks passed
@antazoey antazoey deleted the fix/better-gas-default branch October 4, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants