Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with default optimization(s) #124

Merged
merged 5 commits into from
Jul 8, 2024
Merged

fix: issue with default optimization(s) #124

merged 5 commits into from
Jul 8, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Jul 8, 2024

What I did

  • fix: issue where was using the wrong default optimization for Vyper contracts 0.3.10 and greater (was using codesize by default instead of gas)
  • fix: issue where it attempts to use codesize for contracts < 0.3.10, which for some reason was working, not sure how... but doesn't seem correct.

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey marked this pull request as ready for review July 8, 2024 20:09
@antazoey antazoey requested a review from fubuloubu July 8, 2024 20:10
fubuloubu
fubuloubu previously approved these changes Jul 8, 2024
View reviewed changes
@antazoey antazoey merged commit 2a9bb55 into ApeWorX:main Jul 8, 2024
9 of 11 checks passed
@antazoey antazoey deleted the fix/default-optimization branch July 8, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @fubuloubu