generated from ApeWorX/project-template
-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: compile ABI-based dependencies at better time #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
changed the title
fix: remove attempt to compile dependencies
fix: compile ABI-based dependencies at better time
Aug 23, 2024
antazoey
force-pushed
the
fix/confusing-error
branch
from
August 23, 2024 18:51
37f0e99
to
f493e36
Compare
this is my result, looks like I can compile. but the
|
This was just fixing those strange warnings you were seeing, I haven't looked into the missing fields yet.
|
4 tasks
bitwise-constructs
previously approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Using dependencies like snekmate for Vyper 0.4 was annoying because Vyper 0.3 range dependencies required being compiled for their abis but not in 0.4 so it is a difficult balance.
This PR compiles ABI-based dependencies at a more apt time, when we are further aware that they are indeed ABI-based dependencies and not site-package based or something else.
How I did it
move stuff around
How to verify it
Use snekmate via config like this:
Use something in the Token.vy like @Ninjagod1251 did.
compile
Should not see warning anymore.
Also it compiles much faster and is cleaner
Checklist