Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use new patched pydantic settings #2276

Merged
merged 3 commits into from
Sep 11, 2024
Merged

chore: use new patched pydantic settings #2276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34e204a
fix: use new pydantic settings
antazoey Sep 11, 2024
b0214e3
chore: up pin
antazoey Sep 11, 2024
c7b819a
test: make test play nicer
antazoey Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
"pandas>=2.2.2,<3",
"pluggy>=1.3,<2",
"pydantic>=2.6.4,<3",
"pydantic-settings>=2.4.0,<2.5", # Bug in pydantic_settings
"pydantic-settings>=2.5.2,<3",
"pytest>=8.0,<9.0",
"python-dateutil>=2.8.2,<3",
"PyYAML>=5.0,<7",
Expand Down
3 changes: 2 additions & 1 deletion tests/functional/test_project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,13 @@ def test_isolate_in_tempdir_does_not_alter_sources(project):
try:
with project.isolate_in_tempdir() as tmp_project:
# The new (bad) source should be in the temp project.
assert "tests/newsource.json" in (tmp_project.manifest.sources or {}), project.path
actual = {**(tmp_project.manifest.sources or {})}
finally:
new_src.unlink()
project.sources.refresh()

# Ensure "newsource" did not persist in the in-memory manifest.
assert "tests/newsource.json" in actual, project.path
assert "tests/newsource.json" not in (project.manifest.sources or {})


Expand Down
Loading