fix: invalid integer when using -v flag in ape test
#2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
force-pushed
the
fix/verbosity-typing
branch
from
37e2762
to
ab771a5
Compare
bitwise-constructs
previously approved these changes
Sep 18, 2024
Agreed it is weird, I may consult with |
|
So click recommends making a custom type: pallets/click#1729 |
bitwise-constructs
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
For some reason,
ape test -v debugwas no longer working - I was getting an Invalid Integer problem.How I did it
Hack click to ignore type checking..
I wish the callback was enough for this but I guess click does what it wants.
How to verify it
Run:
ape test -v debugChecklist