fix: add keccak256 as alias for sha3 opcode [APE-1262] #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the opcode was renamed in geth and erigon, but still called sha3 in reth ethereum/go-ethereum#23976 erigontech/erigon#5890
vany365
changed the title
fubuloubu
approved these changes
Aug 4, 2023
antazoey
approved these changes
Aug 7, 2023
antazoey
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
sha3opcode was renamed tokeccak256in geth, and it got it renamed in erigon vmtrace outputethereum/go-ethereum#23976
erigontech/erigon#5890
How I did it
add
keccak256as alias forsha3opcodeHow to verify it
vm tracing is broken in erigon post shanghai, but you can try with this patch of mine.
as for reth, you can track vmtrace compatibility here, but it seems far from usable.
Checklist