Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non-standard tags from Github API #113

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Handle non-standard tags from Github API #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion solcx/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,12 @@ def get_compilable_solc_versions(headers: Optional[Dict] = None) -> List[Version
raise ConnectionError(msg)

for release in data.json():
version = Version.coerce(release["tag_name"].lstrip("v"))
try:
version = Version.coerce(release["tag_name"].lstrip("v"))
except ValueError:
# ignore non-standard releases (e.g. the 0.8.x preview)
continue

asset = next((i for i in release["assets"] if re.match(pattern, i["name"])), False)
if asset:
version_list.append(version)
Expand Down