Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: raise UsageError #165

Merged
merged 4 commits into from
Nov 1, 2024
Merged

fix: raise UsageError #165

merged 4 commits into from
Nov 1, 2024

Conversation

dtdang
Copy link
Contributor

@dtdang dtdang commented Nov 1, 2024 •
edited
Loading

What I did

Http failure in client code should catch and re-raise those issues as click.UsageError exceptions instead of RuntimeError

fixes: #

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@dtdang dtdang requested a review from fubuloubu November 1, 2024 19:45
fubuloubu
fubuloubu previously approved these changes Nov 1, 2024
View reviewed changes
silverback/exceptions.py Show resolved Hide resolved
@dtdang dtdang enabled auto-merge (squash) November 1, 2024 21:07
@dtdang dtdang merged commit 8fc21d8 into ApeWorX:main Nov 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtdang @fubuloubu