Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change variable endpoint to vars #176

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

dtdang
Copy link
Contributor

@dtdang dtdang commented Dec 18, 2024

What I did

Cluster variable endpoints are now /vars instead of /variables.

fixes: #

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@dtdang dtdang enabled auto-merge (squash) December 18, 2024 21:48
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with this

cc @johnson2427 don't make the change upstream

@dtdang dtdang merged commit 32e11e4 into ApeWorX:main Dec 18, 2024
13 checks passed
@dtdang dtdang deleted the fix/cluster_paths branch December 18, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants