Change string map to hold key/value pairs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 854005c.
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
This makes it easier for us to recover from errors. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
nnmm
reviewed
Feb 28, 2023
| string_map->impl->keys = NULL; | ||
| allocator.deallocate(string_map->impl->values, allocator.state); | ||
| string_map->impl->values = NULL; | ||
| __clear_string_map(string_map); |
There was a problem hiding this comment.
This call isn't strictly necessary, because if the size were non-zero, we wouldn't end up at this line. I think I'll remove it, but let me know if you prefer to keep it in just in case, then I'll re-add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier for us to recover from errors.
I've also added in a test here to ensure that we are doing the right thing.
This change is