Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regex to allow dot between parameters in path #158

Merged
merged 2 commits into from
Jun 19, 2020

Conversation

dang-gyg
Copy link
Contributor

Related issue: #157

the SEG_MATCH_REGEX fix allows correct parsing of Path Segments in a path

the PATH_MATCH_REGEX fix allows correct validation for path format. The following will pass:

/resources/{fooId}/subresources/{barId}.{ext}
/resources/{fooId}/subresources/{barId}
/resources/{fooId}/subresources/report.{format}

but not

/resources/{fooId}/subresources/{barId}{ext}

Some references:

@dang-gyg
Copy link
Contributor Author

@EricWittmann please help assign reviewers. I forgot to do it when creating the PR.

@EricWittmann EricWittmann self-requested a review June 19, 2020 20:10
@EricWittmann
Copy link
Member

Looks good to me - thanks for the contribution!

@EricWittmann EricWittmann merged commit 9f0b2e9 into Apicurio:master Jun 19, 2020
@dang-gyg dang-gyg deleted the apicurio-data-models-157 branch June 20, 2020 09:18
@dang-gyg
Copy link
Contributor Author

@EricWittmann any plans when the new version is released?

@EricWittmann
Copy link
Member

I have another bug to fix (was planning on doing it today) and then I will perform a release. So hopefully today.

@EricWittmann
Copy link
Member

This won't happen today but hopefully tomorrow.

@EricWittmann
Copy link
Member

I'm working on the release - we're using a new release process that is GitHub Actions based and I'm working out the kinks. Sorry for the delay.

@EricWittmann
Copy link
Member

OK the process still needs to be refined, but the release is done in both NPM and Maven Central. FYI

@dang-gyg
Copy link
Contributor Author

super 🎉 thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants