Stabilize CI pipelines #5108
Merged
Stabilize CI pipelines #5108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlesarnal
changed the title
carlesarnal
force-pushed
the
stabilize-ci
branch
2 times, most recently
from
6f39359 to
4484a8d
Compare
carlesarnal
force-pushed
the
stabilize-ci
branch
from
4484a8d to
7145e1e
Compare
|
Interesting changes - can you explain the reasoning for them? I'm curious. :) |
carlesarnal
force-pushed
the
stabilize-ci
branch
from
bdb2f1a to
59f45aa
Compare
carlesarnal
commented
Sep 3, 2024
| @@ -59,7 +59,7 @@ jobs: | |||
| run: mvn -N io.takari:maven:wrapper -Dmaven=3.8.2 | |||
|
|
|||
| - name: Build Application | |||
| run: ./mvnw -T 1.5C clean install --no-transfer-progress -Pprod -DskipTests=true -Dmaven.javadoc.skip=true -Dmaven.wagon.httpconnectionManager.maxTotal=30 -Dmaven.wagon.http.retryHandler.count=5 | |||
There was a problem hiding this comment.
You'll see a bunch of this. The application was being built in parallel, meaning that multiple modules were being built at the same time. Code generation invocation was not thread-safe, leading to a bunch of transient errors "related" to Kiota (quoted since the errors aren't caused by Kiota, just happening during that phase).
carlesarnal
commented
Sep 3, 2024
| @@ -352,9 +352,9 @@ jobs: | |||
| echo "Starting Registry App (In Memory)" | |||
| docker run -it -p 8181:8080 -e apicurio.rest.deletion.artifact.enabled=true -d ttl.sh/${{ github.sha }}/apicurio/apicurio-registry:1d | |||
| cd registry-v2 | |||
| ./mvnw -T 1.5C -Pintegration-tests clean install -DskipTests=true -DskipUiBuild=true -Dmaven.javadoc.skip=true | |||
There was a problem hiding this comment.
Also changing from install to package since it makes very little sense to install things in the local repository here.
carlesarnal
force-pushed
the
stabilize-ci
branch
from
59f45aa to
0725b06
Compare
carlesarnal
force-pushed
the
stabilize-ci
branch
3 times, most recently
from
1bc0231 to
8fd0373
Compare
carlesarnal
force-pushed
the
stabilize-ci
branch
from
8fd0373 to
4159680
Compare
carlesarnal
force-pushed
the
stabilize-ci
branch
2 times, most recently
from
90e8ac7 to
14cdfd5
Compare
carlesarnal
force-pushed
the
stabilize-ci
branch
from
14cdfd5 to
06ec871
Compare
carlesarnal
force-pushed
the
stabilize-ci
branch
3 times, most recently
from
27ed393 to
adf6f08
Compare
carlesarnal
force-pushed
the
stabilize-ci
branch
from
adf6f08 to
1ca58cc
Compare
carlesarnal
force-pushed
the
stabilize-ci
branch
2 times, most recently
from
0eec49a to
d82b759
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes to address a few transient failures in CI:
installgoal to speed up the full process.Before merging, this PR has to be squashed to prevent polluting the history.