Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a basic Sql Datasource for operator #5363

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Add a basic Sql Datasource for operator #5363

merged 3 commits into from
Oct 21, 2024

Conversation

andreaTP
Copy link
Member

No description provided.

@andreaTP andreaTP requested a review from jsenko October 17, 2024 16:01
jsenko
jsenko approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@jsenko jsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move the constants and the function to a separate class, but LGTM for now.

@andreaTP andreaTP enabled auto-merge (squash) October 21, 2024 14:28
@andreaTP andreaTP merged commit 20c04bb into Apicurio:main Oct 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsenko jsenko jsenko approved these changes

Assignees
No one assigned
Labels
area/storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaTP @jsenko