[2.6.x] Update keycloakjs and use access_token instead of id_token for oidc code path #5371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nonce support in urls was removed in Keycloak 25 to be fully oidc compatible. But this change is not compatible with old keycloakjs version. Apicurio used a very old version and was broken after this keycloak release.
If the oidc client auth library is used (instead of the default keycloakjs on) the id_token is used as Bearer Token. This is not standard compatible. ID Tokens only contain user information and should never be used for authentications.
|
Thank you for creating a pull request! Pinging @EricWittmann to respond or triage. |
|
This looks correct I think, but since we don't have automated tests in the browser for authentication I have to manually test this PR. I'll add that to my list. Thanks for the contribution. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5085