Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A boolean parameters can be configured with both :bool and :boolean #124

Merged
merged 1 commit into from
Dec 12, 2015

Conversation

Nerian
Copy link
Contributor

@Nerian Nerian commented May 30, 2013

A boolean parameters can be configured with both :bool and :boolean options. A boolean parameter can be any of: 'true', 'false', '1', '0'

@sirMackk
Copy link

sirMackk commented Jun 5, 2013

+1. I think this would be nice for form input.

@Nerian
Copy link
Contributor Author

Nerian commented Jul 19, 2013

Any feedback on this?

2 similar comments
@Nerian
Copy link
Contributor Author

Nerian commented Dec 7, 2013

Any feedback on this?

@Nerian
Copy link
Contributor Author

Nerian commented May 17, 2014

Any feedback on this?

…ptions. A boolean parameter can be any of: 'true', 'false', '1', '0'
@iNecas
Copy link
Member

iNecas commented May 18, 2014

Why not…

@iNecas
Copy link
Member

iNecas commented May 18, 2014

However, I can imagine cases, that somebody already might have, that did not follow this be behavior, now would cause the documentation claiming 0 and 1 is valid value as well. Maybe some enhanced bool might be introduced instead, something like :rails_bool or :form_bool?

@iNecas
Copy link
Member

iNecas commented May 18, 2014

And thanks for the patience BTW! :)

@Nerian
Copy link
Contributor Author

Nerian commented May 28, 2014

I am not sure I follow :)

@Pajk
Copy link
Member

Pajk commented Dec 12, 2015

@Nerian @iNecas What do you think about this in 2015:)? I like the change and I don't think it should cause some serious troubles to anyone. Even if it does it will be mentioned in change log for next version so ppl will be aware of it.

@Nerian
Copy link
Contributor Author

Nerian commented Dec 12, 2015

Awesome 👍

@Pajk Pajk added this to the v0.3.6 milestone Dec 12, 2015
Pajk added a commit that referenced this pull request Dec 12, 2015
A boolean parameters can be configured with both :bool and :boolean
@Pajk Pajk merged commit da6c8b2 into Apipie:master Dec 12, 2015
@iNecas
Copy link
Member

iNecas commented Feb 18, 2016

Aaaan v0.3.6 with this change has just been released

@iNecas
Copy link
Member

iNecas commented Feb 18, 2016

Thanks for patience @Nerian :)

@Nerian
Copy link
Contributor Author

Nerian commented Feb 18, 2016

wooot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants