Restore Ruby 1.8.7 compatibility with lambda styles etc. #272
Conversation
| @@ -175,7 +175,7 @@ def description | |||
| "Must be an array of #{items}" | |||
| end | |||
|
|
|||
| def self.build(param_description, argument, options={}, block) | |||
| def self.build(param_description, argument, options, block) | |||
There was a problem hiding this comment.
what does this change affect?
There was a problem hiding this comment.
Nothing AFAICT, as https://github.com/domcleal/apipie-rails/blob/ruby18/lib/apipie/validator.rb#L24 calls this with the options argument every time.
|
1.8.7 has reached its end of life, we should not support it. People should stay with previous version of Apipie-Rails if they wish to use a not maintained Ruby version. |
|
I'm fine if you don't want to continue to support it, but I'd not expect support to be dropped in a patch release. |
Yes, we should do it in a major release not in a patch release. |
|
@domcleal thanks for going though the code and fixing it for your usecase. The Foreman is one of greatest open-source users of Apipie and we thank it's team to many contributions. I'm ok with this getting in and releaseing |
|
@iNecas sounds good to me, thanks! |
|
I've released apipie-rails 0.2.4 that include this changes. I've also included an information that the master and |
|
Thanks @iNecas, the help's much appreciated! |
|
👍 |
You'll hate me for this, I know, but 0.2.3 broke 1.8 compatibility in lib/. spec/ had a couple of issues already but otherwise 0.2.2 worked great, despite 87b2158.