Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for defining headers for API methods. #341

Merged
merged 1 commit into from
Mar 23, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions app/views/apipie/apipies/_headers.html.erb
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<% unless headers.blank? %>
<%= heading(t('apipie.headers'), h_level) %>
<table class='table'>
<thead>
<tr>
<th><%= t('apipie.header_name') %></th>
<th><%= t('apipie.description') %></th>
</tr>
</thead>
<tbody>
<% headers.each do |header| %>
<tr>
<td>
<strong><%= header[:name] %> </strong><br>
<small>
<%= header[:options][:required] ? t('apipie.required') : t('apipie.optional') %>
</small>
</td>
<td>
<%= header[:description].html_safe %>
</td>
</tr>
<% end %>
</tbody>
</table>
<% end %>
2 changes: 2 additions & 0 deletions app/views/apipie/apipies/_method_detail.erb
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,5 @@
</tbody>
</table>
<% end %>

<%= render(:partial => "headers", :locals => {:headers => method[:headers], :h_level => h_level }) %>
2 changes: 2 additions & 0 deletions app/views/apipie/apipies/resource.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
<%= @resource[:formats].join(', ') %>
<% end %>

<%= render(:partial => 'headers', :locals => { headers: @resource[:headers], h_level: 2 }) %>

<div class='accordion' id='accordion'>

<% @resource[:methods].each do |m| %>
Expand Down
2 changes: 2 additions & 0 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,6 @@ en:
enable_javascript_html: Please enable JavaScript to view the %{comments_href}.
comments_powered_by_disqus: comments powered by %{disqus}
api_documentation: API documentation
headers: Headers
header_name: Header name

19 changes: 18 additions & 1 deletion lib/apipie/dsl_definition.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ def _apipie_dsl_data_init
:api_from_routes => nil,
:errors => [],
:params => [],
:headers => [],
:resouce_id => nil,
:short_description => nil,
:description => nil,
Expand Down Expand Up @@ -129,7 +130,6 @@ def resource_description(options = {}, &block) #:doc:
end
Apipie.set_controller_versions(self, versions)
end

end

module Common
Expand Down Expand Up @@ -268,6 +268,23 @@ def _apipie_get_method_params(method)
@method_params[method]
end

# Describe request header.
# Headers can't be validated with config.validate_presence = true
#
# Example:
# header 'ClientId', "client-id"
# def show
# render :text => headers['HTTP_CLIENT_ID']
# end
#
def header(header_name, description, options = {}) #:doc
return unless Apipie.active_dsl?
_apipie_dsl_data[:headers] << {
name: header_name,
description: description,
options: options
}
end
end

# this describes the params, it's in separate module because it's
Expand Down
6 changes: 4 additions & 2 deletions lib/apipie/method_description.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def initialize(method, path, desc, options)

end

attr_reader :full_description, :method, :resource, :apis, :examples, :see, :formats, :metadata
attr_reader :full_description, :method, :resource, :apis, :examples, :see, :formats, :metadata, :headers

def initialize(method, resource, dsl_data)
@method = method.to_s
Expand Down Expand Up @@ -48,6 +48,7 @@ def initialize(method, resource, dsl_data)
Apipie::ParamDescription.from_dsl_data(self, args)
end
@params_ordered = ParamDescription.unify(@params_ordered)
@headers = dsl_data[:headers]
end

def id
Expand Down Expand Up @@ -142,7 +143,8 @@ def to_json(lang=nil)
:params => params_ordered.map{ |param| param.to_json(lang) }.flatten,
:examples => @examples,
:metadata => @metadata,
:see => see.map(&:to_json)
:see => see.map(&:to_json),
:headers => headers
}
end

Expand Down
8 changes: 6 additions & 2 deletions lib/apipie/resource_description.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@ module Apipie
# name - human readable alias of resource (Articles)
# id - resouce name
# formats - acceptable request/response format types
# headers - array of headers
class ResourceDescription

attr_reader :controller, :_short_description, :_full_description, :_methods, :_id,
:_path, :_name, :_params_args, :_errors_args, :_formats, :_parent, :_metadata
:_path, :_name, :_params_args, :_errors_args, :_formats, :_parent, :_metadata,
:_headers

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\ 😃 /
    |
👞  👞

This is great ! Thanks <3


def initialize(controller, resource_name, dsl_data = nil, version = nil, &block)

Expand All @@ -39,6 +41,7 @@ def update_from_dsl_data(dsl_data)
@_params_args = dsl_data[:params]
@_metadata = dsl_data[:meta]
@_api_base_url = dsl_data[:api_base_url]
@_headers = dsl_data[:headers]

if dsl_data[:app_info]
Apipie.configuration.app_info[_version] = dsl_data[:app_info]
Expand Down Expand Up @@ -105,7 +108,8 @@ def to_json(method_name = nil, lang = nil)
:version => _version,
:formats => @_formats,
:metadata => @_metadata,
:methods => methods
:methods => methods,
:headers => _headers
}
end

Expand Down
52 changes: 52 additions & 0 deletions spec/controllers/users_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ def compare_hashes(h1, h2)
methods.keys.should include(:create)
methods.keys.should include(:update)
methods.keys.should include(:two_urls)
methods.keys.should include(:action_with_headers)
end

it "should contain info about resource" do
Expand Down Expand Up @@ -444,6 +445,57 @@ def reload_controllers
a.instance_variable_get('@params_ordered').count.should == 9
end

context 'headers' do
context 'for methods' do
let(:expected_required_header) do
{
name: :RequredHeaderName,
description: 'Required header description',
options: {
required: true
}
}
end

let(:expected_optional_header) do
{
name: :OptionalHeaderName,
description: 'Optional header description',
options: {
required: false
}
}
end

it 'contains all headers description in method doc' do
headers = Apipie.get_method_description(UsersController, :action_with_headers).headers
headers.should be_an(Array)

compare_hashes headers[0], expected_required_header
compare_hashes headers[1], expected_optional_header
end
end

context 'for resource' do
let(:expected_resource_header) do
{
name: :CommonHeader,
description: 'Common header description',
options: {
required: true
}
}
end

it 'contains all headers description in resource doc' do
headers = Apipie.get_resource_description(UsersController)._headers
headers.should be_an(Array)

compare_hashes headers[0], expected_resource_header
end
end
end

it "should contain all api method description" do
method_description = Apipie[UsersController, :two_urls]
method_description.class.should be(Apipie::MethodDescription)
Expand Down
6 changes: 6 additions & 0 deletions spec/dummy/app/controllers/users_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ class UsersController < ApplicationController
By default, Rails will compile each template to a method in order to render it. When you alter a template,
Rails will check the file's modification time and recompile it in development mode.
EOS
header :CommonHeader, 'Common header description', required: true
end

description <<-eos
Expand Down Expand Up @@ -278,4 +279,9 @@ def desc_from_file
def create_route
end

api :GET, '/users/action_with_headers'
header :RequredHeaderName, 'Required header description', required: true
header :OptionalHeaderName, 'Optional header description', required: false
def action_with_headers
end
end