Fix route discovery with api! for Rails 5 #465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since rails deprecated some behavior that the old code depended on, we just change it to match what its been doing under the hood all along and avoid having to do a depth first search at the same time.
|
This patch seems to be ok - the error is with the test setup... |
|
Hi, I'm testing this right now + making other things working under Rails 5, I hope to have the resolved soon and get this in. |
Closed
|
@sblackstone Can you rebuild the tests? Seems an random fail |
|
Repro: Expected: Actual: |
|
Any progress? |
|
Closed by #527 |
|
apipie-rails-0.4.0 has just been released, the issues should be resolved there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rails deprecated some behavior that the old code depended on, we
just change it to match what its been doing under the hood all along and
avoid having to do a depth first search at the same time.
See rails/rails@4276b21#diff-ccdef70ce0e95afc8816f47f89b56c60 for the commit that caused the regression...