Fixes #629 #640
Merged
Fixes #629 #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, that one failing build seems to be failing on other PRs as well - if I have time I'll take a look at it as well, but since it's happening on other PRs, and also it's a Rails 4.2 build and my changes are all behind a 5.0 check, I'm pretty confident it's unrelated to this change. |
iNecas
reviewed
Oct 29, 2018
| @@ -22,7 +22,7 @@ class Apipie::Railtie | |||
| prepend Apipie::Extractor::Recorder::FunctionalTestRecording | |||
| end | |||
| else | |||
| ActionController::TestCase.send(:prepend, Apipie::Extractor::Recorder::FunctionalTestRecording) | |||
| ActionController::TestCase::Behavior.send(:prepend, Apipie::Extractor::Recorder::FunctionalTestRecording) | |||
There was a problem hiding this comment.
The new version is not working for me. So I guess the original line was there for a reason, Why not to keep both lines in, so that it works for everyone?
There was a problem hiding this comment.
How sensible! :) Fix made and pushed.
The FunctionalTestRecording module's version of process() was not being called when running tests, which meant @collector was never initialized and so examples were not written to the file. To fix this, we need to prepend FunctionalTestRecording to ActionController::TestCase::Behavior, not ActionController::TestCase, for reasons which I honestly did not manage to determine.
|
Test failure unrelated. Thanks @Marri |
|
apipie-rails-0.5.14 has just been released, including this fix |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FunctionalTestRecordingmodule's version ofprocess()was not being called when running tests, which meant@collectorwas never initialized and so examples were not written to the file.To fix this, we need to prepend
FunctionalTestRecordingtoActionController::TestCase::Behavior, notActionController::TestCase, for reasons which I honestly did not manage to determine. (You can follow some of my debug rambling in the original issue.)I'm not actually clear if this fix is safe to merge as is; presumably the original version is there for a reason, I'd've expected the
prepend()to apply to the subclass as well as the parent, and this may be more version-specific than I'm giving it credit for. My testing was all done against APIPie 0.5.13 and Rails 5.1.6 and Ruby 2.5.1 and RSpec 3.7.2. The full codebase is available at https://github.com/Marri/glowfic.