-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rails 6.1 support in doc generation #702
Conversation
@ofedoren would you mind taking look at this? |
I'm going to apply this PR to fix the package in Fedora. Otherwise, I'd suggest to squash the "remove formatting changes" commit or make the formatting changes as separate commit (of course without removing them later). |
Up for this fixing, thnk you braaahh |
you can try this pr to your Gemfile by adding
|
Forgive my ignorance, but if this PR is squash merged, what's the difference? @voxik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi all, sorry for ignoring PRs, I don't have much time to follow here, but ping rather me than others :)
I'm going to merge this, thanks, @andrew-newell!
@ofedoren can you also release a new version of the lib? |
@vitiokss, sure. I also wanted to add a rel-eng playbook, so it helps with the future releases; probably this/next week. IF I don't release, please ping me again, but angrily. |
@ofedoren any news? :) |
It looks like the changes in rails/rails#35093 broke the use of ActionView::Base.new which should make this library Rails 6.1 compatible.