Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for scheme definition in Swagger docs #710

Merged
merged 2 commits into from
May 19, 2022

Conversation

danleyden
Copy link
Contributor

@danleyden danleyden commented May 5, 2021

A number of client generators require that the scheme is set in the swagger doc so they know to connect via HTTP or HTTPS.

This PR adds support for defining the schemes supported by the API service, with the default being ['https'] (secure by default)

Copy link
Collaborator

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works with #711 ?
Seems highly related, I wonder why they needed to be on different PR ?

@danleyden
Copy link
Contributor Author

This works with #711 ? Seems highly related, I wonder why they needed to be on different PR ?

They are related in terms of being improvements to generated Swagger docs, but they are for unrelated, independent features within the Swagger docs and each PR brings different value to the user.

@mathieujobin
Copy link
Collaborator

This is the next one I would consider including...
I would need the conflict resolved via a rebase. and someone else saying this is desirable.

@ofedoren
Copy link
Contributor

@mathieujobin, well, since the project already has some support for the OpenAPI, I'd say let's try to continue improving that support, so more people can find apipie-rails useful :) But it's all up to you.

@mathieujobin mathieujobin merged commit 9f435d6 into Apipie:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants