Fix 'Method foo.en not found for resource bar' errors with no languages set #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we move forward with this PR? |
|
I don't have permissions to merge, do you? |
|
I don’t :( |
|
I can include this in an upcoming release. thanks |
drcapulet
force-pushed
the
alexc-language
branch
from
39669f3 to
f7d4519
Compare
|
@mathieujobin Updated! |
mathieujobin
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default configuration has
default_locale = 'en'butlanguages = [], so the check below fails. There's probably a cleaner way, but this logic matches that inlib/tasks/apipie.rakethat treats the total set of languages to belanguages + default_local.#565 is at least one of the bug reports related to this.