fix: Controller resource set before version #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you explain ? is it possible to write a test that reproduce the error this is fixing ? |
|
also please update your branch to be up to date, so the tests runs |
Closed
The resource description is set before the controller versions are defined. When the namespaced_resources option is enabled this will lead to wrong resource naming.
|
Thank you for updating your branch... I would not mind merging, but I need to understand what this fixes? |
mathieujobin
requested changes
May 19, 2022
|
@mathieujobin I am not able to write a test for it, since we have decided to move away from apipie due to the state it is in. What it fixes is that the resource name generated when no version is present is different than the one when the version is present. To prevent this we should make sure that the controller versions are set before defining the resource description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource description is set before the controller versions are defined.
When the namespaced_resources option is enabled this will lead to incorrect resource naming.