Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruby 3.2 to the build mix #807

Merged
merged 4 commits into from
Jan 16, 2023
Merged

Add ruby 3.2 to the build mix #807

merged 4 commits into from
Jan 16, 2023

Conversation

mathieujobin
Copy link
Collaborator

No description provided.

@mtasaka
Copy link

mtasaka commented Jan 16, 2023

So ruby3.2 failure maybe just due to Fixnum removal and File.exists? removal on ruby3.2...

(As far as I've checked) the first uninitialized constant Apipie::Validator::IntegerValidator::Fixnum error seems to be bringing about the following so many errors: Replacing Fixnum with Integer clears out most of the errors with leaving some errors due to File.exists? removal, which can be fixed by using File.exist?.

Although Fedora does not execute all of the tests, fixing the above 2 issues makes tests pass executed with ruby3.2 on Fedora rpm:

https://koji.fedoraproject.org/koji/taskinfo?taskID=96188951

@mathieujobin
Copy link
Collaborator Author

Thanks for the hints @mtasaka

I had not dug the issues, this is very helpful. I could apply them quickly and get it to pass.

@mathieujobin mathieujobin merged commit 6b22a90 into master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants