Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startup crash due to typo #869

Merged
merged 1 commit into from
May 12, 2023

Conversation

stormsilver
Copy link
Contributor

This should be get_resource_id. The method remove_method_description was not exercised by the specs so it wasn't caught. (see #864)

This was causing apipie to crash during application boot.

This should be `get_resource_id`. The method `remove_method_description`
was not exercised by the specs so it wasn't caught. (see Apipie#864)

This was causing apipie to crash during application boot.
Copy link
Contributor

@PanosCodes PanosCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀, Thanks for opening a PR

@mathieujobin mathieujobin merged commit 9bd38b1 into Apipie:master May 12, 2023
@stormsilver stormsilver deleted the fix_resource_id_crash branch May 15, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants