Allow resource_name to be inherited #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing the test commands not to show up on Github
* Allow resource_name to be a string, symbol, or proc * Search all the way up the controller hierarchy for a value * Continue searching even if a particular controller doesn't have a resource_description block This is helpful if you have a very structured hierarchy of API controllers and would like to define the naming logic once in a base controller.
stormsilver
force-pushed
the
recursive_parent
branch
from
9d6b770 to
67e3787
Compare
|
mathieujobin
approved these changes
May 16, 2023
stormsilver
added a commit
to rednovalabs/apipie-rails
that referenced
this pull request
May 24, 2023
When using namespaced resources, climbing the controller hierarchy was broken in really specific circumstances. Bug introduced in Apipie#872
stormsilver
added a commit
to rednovalabs/apipie-rails
that referenced
this pull request
May 24, 2023
When using namespaced resources, climbing the controller hierarchy was broken in really specific circumstances. Bug introduced in Apipie#872
stormsilver
added a commit
to rednovalabs/apipie-rails
that referenced
this pull request
May 24, 2023
When using namespaced resources, climbing the controller hierarchy was broken in really specific circumstances. Bug introduced in Apipie#872 (cherry picked from commit 3929761)
mathieujobin
pushed a commit
that referenced
this pull request
May 29, 2023
When using namespaced resources, climbing the controller hierarchy was broken in really specific circumstances. Bug introduced in #872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful if you have a very structured hierarchy of API controllers and would like to define the naming logic once in a base controller.
resource_descriptionblockEdit: I had to set Rubocop's target Ruby version to 2.6 in order to get a bunch of offenses to go away. I'm not sure why that suddenly started happening (my PR from last week didn't have any issues).