Swagger: Adds option to skip default tags #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidwessman
commented
May 30, 2023
davidwessman
commented
- This option allows the resource tags to be manually specified
- Fixes [Feature request] Remove default tags from generated swagger json #759
davidwessman
commented
May 30, 2023
| [@method_description.resource._id] + | ||
| warning_tags + | ||
| @method_description.tag_list.tags | ||
| tags = if Apipie.configuration.generator.swagger.skip_default_tags? |
There was a problem hiding this comment.
Maybe it should be called skip_default_resource_tag since it still allows warning_tags? (Which has a separate config)
There was a problem hiding this comment.
If I'm not mistaken swagger tags are only used in endpoints so I guess it's ok to leave it as is, fine by me either way.
This was referenced May 30, 2023
|
@PanosCodes can you please review this Swagger related change? |
PanosCodes
approved these changes
Jun 3, 2023
| [@method_description.resource._id] + | ||
| warning_tags + | ||
| @method_description.tag_list.tags | ||
| tags = if Apipie.configuration.generator.swagger.skip_default_tags? |
There was a problem hiding this comment.
If I'm not mistaken swagger tags are only used in endpoints so I guess it's ok to leave it as is, fine by me either way.
- This option allows the resource tags to be manually specified - Fixes Apipie#759
davidwessman
force-pushed
the
remove-default-tags
branch
from
6546417 to
5de619a
Compare
|
@PanosCodes Fixed the rubocop warnings and rebased 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.