Performance/RegexpMatch-20240219233128

[github-actions]

Rubocop challenge!

Performance/RegexpMatch

Safe autocorrect: Yes
✅ The autocorrect a cop does is safe (equivalent) by design.

Description

Overview

In Ruby 2.4, String#match?, Regexp#match?, and Symbol#match?
have been added. The methods are faster than match.
Because the methods avoid creating a MatchData object or saving
backref.
So, when MatchData is not used, use match? instead of match.

Examples

# bad
def foo
  if x =~ /re/
    do_something
  end
end

# bad
def foo
  if x !~ /re/
    do_something
  end
end

# bad
def foo
  if x.match(/re/)
    do_something
  end
end

# bad
def foo
  if /re/ === x
    do_something
  end
end

# good
def foo
  if x.match?(/re/)
    do_something
  end
end

# good
def foo
  if !x.match?(/re/)
    do_something
  end
end

# good
def foo
  if x =~ /re/
    do_something(Regexp.last_match)
  end
end

# good
def foo
  if x.match(/re/)
    do_something($~)
  end
end

# good
def foo
  if /re/ === x
    do_something($~)
  end
end

Auto generated by rubocop_challenger

[mathieujobin]

should we merge this or ignore this rule ?

[ekohl]

I'd say this is an improvement. Ruby 3.2 has removed =~ and !~ on non-strings so this code is more reliable as well.