Skip to content
This repository has been archived by the owner on Sep 7, 2021. It is now read-only.

Provide a functional default implementation of register in Endpoints #8

Merged
merged 3 commits into from
Apr 4, 2020
Merged

Provide a functional default implementation of register in Endpoints #8

merged 3 commits into from
Apr 4, 2020

Conversation

PSchmiedmayer
Copy link
Contributor

@PSchmiedmayer PSchmiedmayer commented Apr 4, 2020 •
edited
Loading

Provide a functional default implementation of register in Endpoints

Description

Provide a functional default implementation of register(to routes: RoutesBuilder) for an Endpoint to enable Corvus Users to write composable Endpoints without the need to write a register(to routes: RoutesBuilder) function

Related Issue

Closes #7

How Has This Been Tested?

Ran the test suite

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Provide a functional default implementation for `register(to routes: …
7b917ae 
…RoutesBuilder)` for an `Endpoint` to enable Corvus Users to write composable `Endpoints` without the need to write a `register(to routes: RoutesBuilder)` function
@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Apr 4, 2020
bmikaili
bmikaili suggested changes Apr 4, 2020
View reviewed changes
Copy link
Contributor

@bmikaili bmikaili left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Could you make the mapeachthrowing return implicitly, because swiftlint complains about that

@PSchmiedmayer
Copy link
Contributor Author

@bmikaili The SwiftLint error is fixed 👍

@bmikaili bmikaili merged commit 17fadda into Apodini:develop Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmikaili bmikaili bmikaili approved these changes

Assignees

@bmikaili bmikaili

@PSchmiedmayer PSchmiedmayer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a functional default implementation of register in Endpoints
2 participants
@PSchmiedmayer @bmikaili