Skip to content
This repository has been archived by the owner on Sep 7, 2021. It is now read-only.

Feature/user endpoint #9

Merged
merged 17 commits into from
Apr 9, 2020
Merged

Feature/user endpoint #9

merged 17 commits into from
Apr 9, 2020

Conversation

bmikaili
Copy link
Contributor

@bmikaili bmikaili commented Apr 6, 2020 •
edited
Loading

Improvements for user creation and handling.

Description

  • Changed Login to work with Custom tokens and users
    *.Added protocols CorvusModelUser and CorvusModelUserToken to access their properties in components and make them generically initializable (set token value, username and password hash)
  • Added User component that adds CRUD functionality for Users, their create only returns username, and endpoints are secured so users can only access themselves
  • Changed ModelUser and ModelUserToken occurrences, fixed existing tests to work with changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • SwiftLint throws no warnings or errors.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bmikaili bmikaili added the enhancement New feature or request label Apr 6, 2020
@bmikaili bmikaili requested a review from PSchmiedmayer April 6, 2020 14:06
@bmikaili bmikaili self-assigned this Apr 6, 2020
PSchmiedmayer
PSchmiedmayer reviewed Apr 7, 2020
View reviewed changes
Copy link
Contributor

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already looks really nice. I had a few small comments regarding the CorvusModelUser, otherwise the code looks rally clean 👌

Sources/Corvus/Authentication/CorvusUser.swift Outdated Show resolved Hide resolved
Sources/Corvus/Authentication/CorvusModelUser.swift Show resolved Hide resolved
Sources/Corvus/Endpoints/User.swift Show resolved Hide resolved
Sources/Corvus/Endpoints/User.swift Show resolved Hide resolved
Sources/Corvus/Endpoints/Modifiers/UserAuthModifier.swift Show resolved Hide resolved
PSchmiedmayer
PSchmiedmayer approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@bmikaili bmikaili merged commit c41fd8b into develop Apr 9, 2020
@PSchmiedmayer PSchmiedmayer deleted the feature/user-endpoint branch April 10, 2020 09:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PSchmiedmayer PSchmiedmayer PSchmiedmayer approved these changes

Assignees

@bmikaili bmikaili

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmikaili @PSchmiedmayer