You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The request validation function today takes Unit identifier, Function code, Address and Quantity of registers.
Do you think it would be possible to also pass the new register value from a write function code? That would allow us to validate the incoming data and possibly return Illegal Data Value exception code if it fails.
The text was updated successfully, but these errors were encountered:
If that is doable in a performant way, I have nothing against it. Maybe it should be a flag (default off) so it does not affect performance if not needed. It would be a bad idea to create a new array, i.e. a new object the garbage collector has to track, for every single request that goes into the server. But I see that there might be the need for it. Could you draft a PR? It can be a breaking change because I am preparing v6 right now.
#134 describes a similar issue and the solution proposed there (a new type for the request validator args) is something I like. So if you consider creating a PR please base the implementation on that branch. Thanks :-)
The request validation function today takes Unit identifier, Function code, Address and Quantity of registers.
Do you think it would be possible to also pass the new register value from a write function code? That would allow us to validate the incoming data and possibly return Illegal Data Value exception code if it fails.
The text was updated successfully, but these errors were encountered: