Expose DisplayName to RequestValidator #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like your solution. Only thing I would change is the name Could you please also update the documentation files |
helynranta
force-pushed
the
feature/request-validator-args
branch
from
7c7959d to
ebd8bef
Compare
- Refactor RequestValidator to take Args object instead of list of parameters (breaking change!) - Add ConnectionName as one of the parameters for user to validate
helynranta
force-pushed
the
feature/request-validator-args
branch
from
ebd8bef to
d0845f6
Compare
|
I rename the variable to |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a need to Validate incoming request to modbus server based on which IP address it is coming from. To do this I exposed
DisplayNameproperty of ModbusRequestHandler to user withRequestValidator. However, adding new parameter is breaking change. So I just ended up adding new args object for it, so next addition don't require changes for users of the library. There is already an issue here for similar need: #133