Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create go import #247

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Create go import #247

merged 3 commits into from
Aug 15, 2024

Conversation

hoganwr
Copy link
Contributor

@hoganwr hoganwr commented Aug 13, 2024

Updates to import GO more properly via ODK slme import.

Since SV used GO's 'reproduction' which is now obsolete, and because GO's 'reproductive process' is overly broad (the host's reproductive processes would qualify, and thus categorize any normal adult host as being infected in error), I also created class in SV called 'reproduction' which is the union of 'asexual reproduction' (to cover bacterial pathogens), 'sexual reproduction' (to cover eukaryotic pathogens that sexually reproduce), and 'viral life cycle' (to cover viral pathogens). We use the new reproduction class where the old GO one was used. We could have just left the class anonymous, but because we use it at least 4 or 5 times, it was much more convenient to "name" it.

Also found problems with class 'contamination acquisition' being not satisfiable due to use of has_specified_input and has_specified_output relations, which I changed to RO's 'has input' and 'has output'.

Fixes #246

…of 'asexual reproduction', 'sexual repreduction', and 'viral life cycle' (all from GO and all now imported into SV), and replaced old GO reproduction with SV's new 'reproduction' everywhere it was used. Also fixed a reasoner error on 'contamination acquisition'. Updated all other imports in addition to creating new GO import.
…uded 'has output' relation from RO to update axiom for 'contamination acquisition'
@hoganwr hoganwr merged commit 31ac4b6 into main Aug 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Superclass for 'infection' ('reproduction') is now obsolete
1 participant