Fix CA1062 warning (#2229)

Fix CA1062 and S4456 warnings for `IPolicyWrapExtension`.
App-vNext · Jul 23, 2024 · b703130 · b703130
1 parent 72331dc
commit b703130
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 14 deletions.
diff --git a/src/Polly/Wrap/IPolicyWrapExtension.cs b/src/Polly/Wrap/IPolicyWrapExtension.cs
@@ -3,7 +3,6 @@
 /// <summary>
 /// Extension methods for IPolicyWrap.
 /// </summary>
-#pragma warning disable CA1062 // Validate arguments of public methods
 public static class IPolicyWrapExtension
 {
     /// <summary>
@@ -13,21 +12,12 @@ public static class IPolicyWrapExtension
     /// <returns>An <see cref="IEnumerable{IsPolicy}"/> of all the policies in the wrap.</returns>
     public static IEnumerable<IsPolicy> GetPolicies(this IPolicyWrap policyWrap)
     {
-        var childPolicies = new[] { policyWrap.Outer, policyWrap.Inner };
-        foreach (var childPolicy in childPolicies)
+        if (policyWrap is null)
         {
-            if (childPolicy is IPolicyWrap anotherWrap)
-            {
-                foreach (var policy in anotherWrap.GetPolicies())
-                {
-                    yield return policy;
-                }
-            }
-            else if (childPolicy != null)
-            {
-                yield return childPolicy;
-            }
+            throw new ArgumentNullException(nameof(policyWrap));
         }
+
+        return GetPoliciesIterator(policyWrap);
     }
 
     /// <summary>
@@ -83,4 +73,23 @@ public static TPolicy GetPolicy<TPolicy>(this IPolicyWrap policyWrap, Func<TPoli
 
         return policyWrap.GetPolicies().OfType<TPolicy>().SingleOrDefault(filter);
     }
+
+    private static IEnumerable<IsPolicy> GetPoliciesIterator(IPolicyWrap policyWrap)
+    {
+        var childPolicies = new[] { policyWrap.Outer, policyWrap.Inner };
+        foreach (var childPolicy in childPolicies)
+        {
+            if (childPolicy is IPolicyWrap anotherWrap)
+            {
+                foreach (var policy in anotherWrap.GetPolicies())
+                {
+                    yield return policy;
+                }
+            }
+            else if (childPolicy != null)
+            {
+                yield return childPolicy;
+            }
+        }
+    }
 }
diff --git a/test/Polly.Specs/Wrap/IPolicyWrapExtensionSpecs.cs b/test/Polly.Specs/Wrap/IPolicyWrapExtensionSpecs.cs
@@ -2,6 +2,15 @@
 
 public class IPolicyWrapExtensionSpecs
 {
+    [Fact]
+    public void Should_throw_when_policy_wrap_is_null()
+    {
+        IPolicyWrap policyWrap = null!;
+
+        var action = () => policyWrap.GetPolicies();
+        action.Should().Throw<ArgumentNullException>().And.ParamName.Should().Be("policyWrap");
+    }
+
     [Fact]
     public void Should_pass_all_nested_policies_from_PolicyWrap_in_same_order_they_were_added()
     {