Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to xunit's default parallel algorithm in Polly.Core.Tests #2288

Open
martincostello opened this issue Sep 16, 2024 · 0 comments
Open
Labels
help wanted A change up for grabs for contributions from the community

Comments

@martincostello
Copy link
Member

xunit 2.8.0+ changes the default algorithm use to run async tests in parallel: docs

This change caused an existing test to fail when dependabot upgraded the project's version of xunit in #2186. This is the specific test that failed:

Having asked over in the xunit repository (see xunit/xunit#3024), a workaround was made to revert back to the previous default algorithm to fix the test and ingest the dependency update: 35967a3

While this fixes the CI and allows us to stay up-to-date with xunit, it isn't the optimal solution.

Instead we should determine how to refactor the test to assert on the required intent (that the hedged action executes on a different thread) of the test so that we can revert the changes in the commit referenced above and instead use xunit's default parallel algorithm (option 3 in the linked discussion).

@martincostello martincostello added the help wanted A change up for grabs for contributions from the community label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted A change up for grabs for contributions from the community
Projects
None yet
Development

No branches or pull requests

1 participant