Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OnHedging not being called #1320

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Fix OnHedging not being called #1320

merged 3 commits into from
Jun 19, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 19, 2023

Details on the issue fix or feature implementation

The OnHedging callback was not called when the outcome is not available due to the callback taking too long.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 19, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 19, 2023
@martintmk martintmk enabled auto-merge (squash) June 19, 2023 08:47
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #1320 (907bde2) into main (ce97ea5) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1320      +/-   ##
==========================================
+ Coverage   83.37%   83.42%   +0.04%     
==========================================
  Files         268      268              
  Lines        6335     6352      +17     
  Branches     1001     1001              
==========================================
+ Hits         5282     5299      +17     
  Misses        844      844              
  Partials      209      209              
Flag Coverage Δ
linux ?
macos 83.42% <100.00%> (+0.04%) ⬆️
windows 83.42% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lly.Core/Hedging/HedgingStrategyOptions.TResult.cs 100.00% <ø> (ø)
...rc/Polly.Core/Hedging/HedgingResilienceStrategy.cs 100.00% <100.00%> (ø)
src/Polly.Core/Hedging/OnHedgingArguments.cs 100.00% <100.00%> (ø)

@martintmk martintmk merged commit 6fcf0f6 into main Jun 19, 2023
@martintmk martintmk deleted the mtomka/onhedging branch June 19, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants