Introduce ResilienceStrategyBuilder.Validator #1412
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
This API addition allows the library to inject their own validator and get rid of the reflection that is used in the default validator.
This allows the library that consumes the Polly to be AOT compatible.
In ideal world we could just use the generators introduced by dotnet/runtime#85475.
However, this would pull the heavy
Microsoft.Extensions.Options
dependency into the core package.As a follow-up task after #1360 is merged we can introduce
ResilienceValidator.Validate
utility API inPolly.Extensions
that uses generated validators for validation and doesn't use reflection at all (for all built-in options).Contributes to #1110
Confirm the following