Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the ResilienceStrategyBuilder.IsGenericBuilder property #1431

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jul 26, 2023

Details on the issue fix or feature implementation

Follow-up of #1430

It was internal API that's not required anymore.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 26, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #1431 (940a005) into main (2410e68) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1431      +/-   ##
==========================================
- Coverage   83.93%   83.91%   -0.02%     
==========================================
  Files         276      276              
  Lines        6528     6520       -8     
  Branches     1005     1005              
==========================================
- Hits         5479     5471       -8     
  Misses        840      840              
  Partials      209      209              
Flag Coverage Δ
linux ?
macos 83.91% <100.00%> (-0.02%) ⬇️
windows 83.91% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rc/Polly.Core/ResilienceStrategyBuilder.TResult.cs 100.00% <ø> (ø)
src/Polly.Core/ResilienceStrategyBuilder.cs 100.00% <ø> (ø)
src/Polly.Core/ResilienceStrategyBuilderBase.cs 100.00% <ø> (ø)
src/Polly.Core/ResilienceStrategyBuilderContext.cs 100.00% <ø> (ø)
src/Polly.Core/Fallback/FallbackHandler.cs 100.00% <100.00%> (ø)
...ack/FallbackResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)
...ging/HedgingResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)

@martintmk martintmk enabled auto-merge (squash) July 26, 2023 07:46
@martintmk martintmk merged commit 3537c74 into main Jul 26, 2023
16 checks passed
@martintmk martintmk deleted the mtomka/cleanup-builders branch July 26, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants