Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop simple circuit breaker #1444

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jul 28, 2023

Details on the issue fix or feature implementation

Per the API review at #1233:

  • Drops SimpleCircuitBreaker
  • AdvancedCircuitBreaker renamed to CircuitBreaker

Contributes to #1301

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 28, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #1444 (08f27aa) into main (a51b44d) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1444      +/-   ##
==========================================
- Coverage   83.94%   83.87%   -0.07%     
==========================================
  Files         276      273       -3     
  Lines        6533     6505      -28     
  Branches     1013     1010       -3     
==========================================
- Hits         5484     5456      -28     
  Misses        840      840              
  Partials      209      209              
Flag Coverage Δ
macos 83.87% <100.00%> (-0.07%) ⬇️
windows 83.87% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...lly.Core/CircuitBreaker/CircuitBreakerConstants.cs 100.00% <ø> (ø)
...rcuitBreakerResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)
...Core/CircuitBreaker/CircuitBreakerStateProvider.cs 100.00% <100.00%> (ø)
...itBreaker/CircuitBreakerStrategyOptions.TResult.cs 100.00% <100.00%> (ø)
...rcuitBreaker/Controller/AdvancedCircuitBehavior.cs 100.00% <100.00%> (ø)

public class CircuitBreakerStrategyOptions<TResult> : ResilienceStrategyOptions
{
/// <summary>
/// Gets or sets the failure threshold at which the circuit will break.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Gets or sets the failure threshold at which the circuit will break.
/// Gets or sets the failure-to-success ratio at which the circuit will break.

@martintmk martintmk enabled auto-merge (squash) July 28, 2023 05:38
@martintmk martintmk merged commit adb65f8 into main Jul 28, 2023
12 checks passed
@martintmk martintmk deleted the mtomka/drop-simple-cirucit-breaker branch July 28, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants