Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unnecessary allocation in circuit breaker #1464

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 8, 2023

Details on the issue fix or feature implementation

For some strange reason the inline lambda allocates 32 bytes even if that branch is not accessed. With small change we can avoid this.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 8, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1464 (caa0f2c) into main (4153d2a) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1464   +/-   ##
=======================================
  Coverage   83.89%   83.89%           
=======================================
  Files         276      275    -1     
  Lines        6495     6495           
  Branches     1015     1015           
=======================================
  Hits         5449     5449           
  Misses        837      837           
  Partials      209      209           
Flag Coverage Δ
linux 83.89% <100.00%> (ø)
macos 83.89% <100.00%> (?)
windows 83.89% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ircuitBreaker/Controller/CircuitStateController.cs 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@martintmk martintmk merged commit e8c33db into main Aug 8, 2023
16 checks passed
@martintmk martintmk deleted the mtomka/drop-unnecessary-allocation branch August 8, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants