-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResiliencePipelineRegistry
is now disposable
#1496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martintmk
changed the title
ResiliencePipelineRegistry is now disposable
Aug 17, 2023
ResiliencePipelineRegistry
is now disposable
Codecov Report
@@ Coverage Diff @@
## main #1496 +/- ##
==========================================
+ Coverage 83.59% 83.88% +0.29%
==========================================
Files 268 269 +1
Lines 6377 6492 +115
Branches 1007 1024 +17
==========================================
+ Hits 5331 5446 +115
Misses 837 837
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martintmk
force-pushed
the
mtomka/dispose-support
branch
from
August 17, 2023 10:50
deba4ce
to
bdbcb02
Compare
martintmk
force-pushed
the
mtomka/dispose-support
branch
from
August 17, 2023 10:52
bdbcb02
to
d09f162
Compare
martincostello
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the Issue Fix or Feature Implementation
The
ResiliencePipeline
can hold disposable resources such asRateLimiter
orCircuitBreaker
. This PR enables theResiliencePipelineRegistry
to manage and dispose of these resources transparently when necessary. Key changes include:AddResiliencePipeline
DI extension are now seamlessly managed by both the registry and the DI infrastructure.ResiliencePipelineRegistry
will also dispose of all associated pipelines and their resources.I chose not to expose
IDisposable
andIAsyncDisposable
onResiliencePipeline
as it compromises the API user experience (VS would flag the pipelines for disposal). Instead, we recommend using the registry or DI where such concerns are not present. We can add disposal support toResiliencePipeline
in the future, if there is a demand.In standalone mode, as a workaround, users can manually dispose of the resources. Here's an example:
Additional Changes:
RateLimiterResilienceStrategy
is now disposable.CircuitBreakerResilienceStrategy
is also disposable.CircuitBreakerManualControl
.CircuitBreakerManualControl
is no longer disposable.This PR contributes to the discussion at #1233 (comment).
Confirm the Following: