Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Review Feedback #1521

Merged
merged 3 commits into from
Aug 29, 2023
Merged

API Review Feedback #1521

merged 3 commits into from
Aug 29, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 28, 2023

Details on the issue fix or feature implementation

  • Simplify property names when the name is clear (i.e. HedgingDelay -> Delay)
  • Rename RetryBackoffType to DelayBackoffType to make it more universal as it can be used by other strategies later.
  • Rename RetryCount to MaxRetryAttempts to make it alligned with hedging (MaxHedgingAttempts) and to make it clear that retry strategy can exit sooner than that.
  • MaxHedgingAttempts with value 1 is now valid. (the initial attempt does not count, similar to how retry strategy works)

Contributes to #1507

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 28, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #1521 (a50d85a) into main (daf1529) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1521   +/-   ##
=======================================
  Coverage   84.11%   84.11%           
=======================================
  Files         278      278           
  Lines        6586     6586           
  Branches     1026     1026           
=======================================
  Hits         5540     5540           
  Misses        837      837           
  Partials      209      209           
Flag Coverage Δ
linux 84.11% <100.00%> (ø)
macos 84.11% <100.00%> (ø)
windows 84.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ly.Core/Hedging/HedgingActionGeneratorArguments.cs 100.00% <ø> (ø)
src/Polly.Core/Hedging/HedgingConstants.cs 100.00% <ø> (ø)
src/Polly.Core/Retry/RetryConstants.cs 100.00% <ø> (ø)
...c/Polly.Core/Retry/RetryDelayGeneratorArguments.cs 100.00% <ø> (ø)
...ging/HedgingResiliencePipelineBuilderExtensions.cs 100.00% <100.00%> (ø)
...rc/Polly.Core/Hedging/HedgingResilienceStrategy.cs 100.00% <100.00%> (ø)
...lly.Core/Hedging/HedgingStrategyOptions.TResult.cs 100.00% <100.00%> (ø)
src/Polly.Core/Retry/RetryHelper.cs 100.00% <100.00%> (ø)
src/Polly.Core/Retry/RetryResilienceStrategy.cs 100.00% <100.00%> (ø)
...c/Polly.Core/Retry/RetryStrategyOptions.TResult.cs 100.00% <100.00%> (ø)

@martintmk martintmk merged commit 94db492 into main Aug 29, 2023
16 checks passed
@martintmk martintmk deleted the mtomka/api-feedback-2 branch August 29, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants